Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] Run clang-format on codebase #46

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

PabstMirror
Copy link

  • rename files to .cs
  • run clang-format on them
  • rename back

Please look at commit a97a3e0 too see the real changes (ignoring tab replacement)

enf seems very close to csharp so clang is handling it pretty well
We can change style to whatever we want ({ on same line is more ace3 style)

@Kexanone
Copy link
Member

Kexanone commented Apr 11, 2024

Great for keeping things consistent, but please go back to Allman style, since that's what should be used based on BI conventions. Also use tabs instead of spaces for indentation, since the WB script editor can only handle the former properly.

@Drofseh
Copy link

Drofseh commented Apr 11, 2024

I really hate the Allman braces and don't see a real need to follow that convention as long as the game loads properly.

@Kexanone
Copy link
Member

Both Allman and K&R are reasonable styles and widely used in the world of programming. You pick whatever makes sense in a particular language and project regardless of personal preferences. And this is definitely Allman in Enfusion. In practice, you will have to go through a lot of BI code to find the suitable entry points or parts you want to modify. Once you do, you make a copy of the file you want to mod. Changing the indentation style would just be plain annoying.

@Kexanone Kexanone added kind/cleanup Release Notes: Excluded ignore-changelog Release Notes: Excluded labels Apr 13, 2024
@Kexanone Kexanone added this to the Ongoing milestone Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/cleanup Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants