Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carrying - Fixes for experimental #65

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Carrying - Fixes for experimental #65

merged 9 commits into from
Jul 9, 2024

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented May 24, 2024 •
edited
Loading

When merged this pull request will:

  • ECompartmentType values are now capitalized
  • Use the new GetOutVehicle_NoDoor method

Additional notes:

@Kexanone Kexanone added kind/bug Release Notes: **FIXED:** 1.2 labels May 24, 2024
@Kexanone Kexanone added this to the 1.1.0 milestone May 24, 2024
@Kexanone Kexanone changed the base branch from master to experimental May 26, 2024 13:51
@Kexanone Kexanone changed the base branch from experimental to master June 26, 2024 18:40
@Kexanone Kexanone modified the milestones: 1.1.0, 1.1.1, Ongoing Jun 26, 2024
@veteran29 veteran29 marked this pull request as ready for review July 1, 2024 21:33
veteran29
veteran29 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kexanone Kexanone marked this pull request as draft July 1, 2024 22:56
@Kexanone
Copy link
Member Author

Kexanone commented Jul 9, 2024

LGTM

@Kexanone Kexanone marked this pull request as ready for review July 9, 2024 22:46
@Kexanone Kexanone merged commit c93559e into master Jul 9, 2024
@Kexanone Kexanone deleted the carrying/fixes branch July 9, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
1.2 kind/bug Release Notes: **FIXED:**
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @veteran29