Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HitReaction - CBA Settings - Min Damage to trigger falling - negative value #10388

Closed
OverlordZorn opened this issue Oct 10, 2024 · 5 comments · Fixed by #10400
Closed

HitReaction - CBA Settings - Min Damage to trigger falling - negative value #10388

OverlordZorn opened this issue Oct 10, 2024 · 5 comments · Fixed by #10400
Labels
Milestone

Comments

@OverlordZorn
Copy link
Contributor

image

  • Min Damage to trigger falling can be negative
    -> What is negative damage?
    -> Are people falling when they are being healed?

no hoverover-tooltip so there is no indication in what is supposed to do in any way.

@hennessydylan

This comment was marked as off-topic.

@hennessydylan

This comment was marked as off-topic.

@OverlordZorn

This comment was marked as off-topic.

@johnb432
Copy link
Contributor

johnb432 commented Oct 12, 2024

-1 means the system is disabled. I'm not sure about ]-1, 0] though, will investigate.

EDIT: Damage from Hit doesn't seem to ever be negative, so ]-1, 0] exists because -1 is used to disable the mechanic. I'll update the tooltip and change it so that any negative number is considered turned off.

@johnb432 johnb432 linked a pull request Oct 12, 2024 that will close this issue
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 12, 2024
@Andx667
Copy link
Contributor

Andx667 commented Oct 13, 2024

imho this should just be a range from 0 to 1 with a fallback that maps negative values to -1 or wahtever disabled is.

@LinkIsGrim LinkIsGrim modified the milestones: 3.18.2, 3.18.1 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants