Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit reactions - Improve fall down setting description #10400

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Changes so that all negative values are considered to turn off this mechanic (instead of just -1).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 12, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 12, 2024
@johnb432 johnb432 changed the title Hit reactions - Improve fall down description Hit reactions - Improve fall down setting description Oct 12, 2024
@PabstMirror
Copy link
Contributor

Possible source of confusion is if someone tries to set to 0
image
this doesn't look negative but is actually -0.0272051

but this more of a cba problem, tbh I'm not sure why it doesn't show -0.0

@johnb432
Copy link
Contributor Author

Possible source of confusion is if someone tries to set to 0 image this doesn't look negative but is actually -0.0272051

but this more of a cba problem, tbh I'm not sure why it doesn't show -0.0

Tbh I'm not really happy with the slider either, having -1 be the disabling value and ]-1, 0[ unused is poor design imo.
Ideally, imo, 0 would mean turned off - but I don't really want to change the slider range, as it could invalidate people's existing settings.

johnb432 and others added 2 commits October 13, 2024 00:35
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim LinkIsGrim merged commit 92a997d into master Oct 14, 2024
3 of 4 checks passed
@LinkIsGrim LinkIsGrim modified the milestones: 3.18.2, 3.18.1 Oct 14, 2024
@LinkIsGrim LinkIsGrim deleted the hitreactions-improve-fall-down branch October 14, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HitReaction - CBA Settings - Min Damage to trigger falling - negative value
3 participants