Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of bugs with medical menu #2528

Closed
gienkov opened this issue Sep 19, 2015 · 3 comments
Closed

Bunch of bugs with medical menu #2528

gienkov opened this issue Sep 19, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@gienkov
Copy link
Contributor

gienkov commented Sep 19, 2015

  1. You can use medical menu on units that are very far
  2. You cannot use drag from inside medical menu (option category is greyed out)
  3. You can use "Stitch wounds" action on every body part but on old 3D medical you can use this option only on torso
  4. STR_ace_medical_Activity_fullHeal http://images.akamai.steamusercontent.com/ugc/422566661700086717/D9C4BFCB60EA57B9404B975D4715009515E7E5E0/
  5. Information on when something was given is shown in wrong format - in minutes as opposed to hours like in ACE3 3.2.x: http://images.akamai.steamusercontent.com/ugc/422566661700086271/27A173CCA6E8A18756765541FE6262A28540495E/
  6. Information that something was given X minutes ago is not always shown, may be related to issue above

All tested on dedicated.

@PabstMirror
Copy link
Contributor

Fixed 4 and 5.

  1. MEDICAL_ACTION_DISTANCE is 1.75m, the medical menu should be something similar.
  2. We'll have to add to treatments, but dragging isn't guarented to be there, so we'll have to duplicate the strings, and add safe helper functions in case drag isn't there.
class Drag {
    displayName = CSTRING(drag);
    category = "drag";
    treatmentLocations[] = {"All"};
    allowedSelections[] = {"All"};
    treatmentTime = 0;
    allowSelfTreatment = 0;
    callbackSuccess = QFUNC(dragHook_startDrag);
    condition = QFUNC(dragHook_canDrag);
};

three. Not sure if this is error, the treatment effects the whole body so it really doesn't matter where it is called from, I think for 3d getting it off of limbs reduces clutter, but for the menu it really doesn't matter. (SurgicalKit/PersonalAidKit both have allowedSelections[] = {"All"};)

six. Is this caused by a specific treatment, or any way you can consistently reproduce this?

@gienkov
Copy link
Contributor Author

gienkov commented Sep 20, 2015

Any treatment.

PabstMirror added a commit that referenced this issue Oct 13, 2015
(1) Verify target is valid and in reasonable range
PabstMirror added a commit that referenced this issue Oct 13, 2015
@PabstMirror PabstMirror added this to the 3.4.0 milestone Nov 12, 2015
@PabstMirror PabstMirror self-assigned this Nov 12, 2015
@PabstMirror
Copy link
Contributor

six - Seems to happen when ace_medical_enableFor is 0.

treatmentAdvanced_bandage will exit to treatmentBasic_bandage before adding the log.

PabstMirror added a commit that referenced this issue Nov 12, 2015
In advanced medical without enableFor AI. Bandaging an AI would exit
before adding log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants