Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nametags and actions on hidden units #2596

Closed
m1ndst0rm opened this issue Sep 25, 2015 · 4 comments
Closed

Remove nametags and actions on hidden units #2596

m1ndst0rm opened this issue Sep 25, 2015 · 4 comments
Labels
Milestone

Comments

@m1ndst0rm
Copy link

ACE3 Version: 3.2.2

Mods:

  • @CBA_A3
  • @ace

Placed ACE3 Modules:

  • ACE_ModuleNameTags

Description:
Both nametags and interaction menu render for players that are hidden with hideObject or hideObjectGlobal.

Please implement isObjectHidden on these two files.
interact_menu/functions/fnc_renderActionPoints.sqf
nametags/functions/fnc_onDraw3d

Steps to reproduce:
Step 1:
Start a mission with a 2nd unit, or object which has ace actions.
otherunit hideObject true;
Step 2:
Open other interaction menu. It will show actions. In case of player it will also show the nametag (MP).

Where did the issue occur?
SP/MP

RPT log file:
//Wont add anything

@jokoho48 jokoho48 added the kind/feature Release Notes: **ADDED:** label Sep 25, 2015
@jokoho48
Copy link
Member

feel free to do it by your self and please read http://ace3mod.com/wiki/user/how-to-make-a-feature-request.html and use #414

@bux
Copy link
Member

bux commented Sep 25, 2015

Or formulate it as a bug report, which is probably more adequate: http://ace3mod.com/wiki/user/how-to-report-an-issue.html

@bux bux added kind/bug and removed kind/feature Release Notes: **ADDED:** labels Sep 25, 2015
@m1ndst0rm
Copy link
Author

Having some issues with my client so i'm posting the fix here. If someone has time please add.

interact_menu/functions/fnc_renderActionPoints.sqf. Line 40
From

if (_target != ACE_player && {_target != vehicle ACE_player}) then {

To:

if (_target != ACE_player && {_target != vehicle ACE_player} && {!(isObjectHidden _target)}) then {

nametags/functions/fnc_onDraw3d Line 107

From:

{!(_target getVariable ["ACE_hideName", false])}) then {

To:

 {!(_target getVariable ["ACE_hideName", false])} &&
 {!(isObjectHidden _target)}) then {

@commy2
Copy link
Contributor

commy2 commented Sep 25, 2015

Probably works for nametags, but there is a better way to do it for actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants