Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic value occurances in the code base #4978

Closed
thojkooi opened this issue Mar 8, 2017 · 2 comments
Closed

Remove magic value occurances in the code base #4978

thojkooi opened this issue Mar 8, 2017 · 2 comments
Milestone

Comments

@thojkooi
Copy link
Contributor

thojkooi commented Mar 8, 2017

We have some magic value occurances in various places in our code base.

One of such examples is #4964.

We should replace those magic values by macro defines. This would be an ongoing issue.

@commy2
Copy link
Contributor

commy2 commented Mar 9, 2017

We almost exclusively use magic numbers without macros for IDC's in ACE:

(_settingsMenu displayCtrl 301) ctrlShow true;
(_settingsMenu displayCtrl 400) ctrlShow true;
(_settingsMenu displayCtrl 410) ctrlShow false;
(_settingsMenu displayCtrl 411) ctrlShow false;
(_settingsMenu displayCtrl 412) ctrlShow false;
(_settingsMenu displayCtrl 413) ctrlShow false;
(_settingsMenu displayCtrl 414) ctrlShow false;
(_settingsMenu displayCtrl 415) ctrlShow false;
(_settingsMenu displayCtrl 416) ctrlShow false;
(_settingsMenu displayCtrl 416) ctrlEnable false;

We also never use the DIK table for key codes:
#include "\a3\ui_f\hpp\defineDIKCodes.inc"

@Mike-MF
Copy link
Member

Mike-MF commented Sep 11, 2023

Closing due to age, inactivity or already solved. May be re-opened if the issue is still present, even better just open a new up-to-date Issue.

@Mike-MF Mike-MF closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants