Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rangecard not showing wind/lead #4964

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Fix rangecard not showing wind/lead #4964

merged 1 commit into from
Mar 8, 2017

Conversation

PabstMirror
Copy link
Contributor

Fix #4962

I think this is right
line 229 does } forEach [0, 3, 8];

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Mar 3, 2017
@PabstMirror PabstMirror added this to the 3.9.1 milestone Mar 3, 2017
thojkooi
thojkooi approved these changes Mar 8, 2017
View reviewed changes
Copy link
Contributor

@thojkooi thojkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This method is slightly confusing overall though, so we might want to look into working away those magic numbers a bit here sometime.

@thojkooi thojkooi mentioned this pull request Mar 8, 2017
Closed
@thojkooi
Copy link
Contributor

thojkooi commented Mar 8, 2017

Created an issue to one day solve that issue. Will track in #4978.

@thojkooi thojkooi merged commit f3d2833 into master Mar 8, 2017
@thojkooi thojkooi deleted the fixRangecard branch March 8, 2017 18:40
thojkooi pushed a commit that referenced this pull request Mar 13, 2017
@PabstMirror @thojkooi
Fix rangecard not showing wind/lead (#4964)
d9be3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thojkooi thojkooi thojkooi approved these changes

Assignees

@ulteq ulteq

Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @thojkooi @ulteq