Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot unload injured from vehicle #5525

Closed
Arcanum417 opened this issue Sep 17, 2017 · 12 comments · Fixed by #5544
Closed

Cannot unload injured from vehicle #5525

Arcanum417 opened this issue Sep 17, 2017 · 12 comments · Fixed by #5544
Assignees
Labels

Comments

@Arcanum417
Copy link
Contributor

Arcanum417 commented Sep 17, 2017

Arma 3 Version: 1.76,142872 (stable)
CBA Version: 3.4.1.170912 (stable)
ACE3 Version: medical-rewrite bdea0fcdbab53d4d5a5d67652f41d37733523447 (dev + commit hash)

Mods:

- CBA_A3
- ace

Description:

  • You always get error there is no space if you try to unload injured player from vehicle.
  • inconsistent behaviour when trying to unload AI

Steps to reproduce:

  • Create mission with two slots and one vehicle
  • Start two instances of Arma3
  • Host the mission on one instance, join with the other
  • Shoot the player until he falls
  • Load injured player into vehicle
  • Mount the vehicle and try to unload the player
  • Or try to unload the player from outside of vehicle

Where did the issue occur?

  • Self-Hosted Multiplayer

Placed Modules:

  • none

RPT log file:

@bux
Copy link
Member

bux commented Sep 17, 2017

https://i.gyazo.com/3aa61e3cde53d7177d6c2ae1b8316434.gif
Happens in current release 3.10.2 too

@bux bux changed the title medical-rewrite cannot unload injured from vehicle Cannot unload injured from vehicle Sep 17, 2017
@bux
Copy link
Member

bux commented Sep 17, 2017

Imho we could just remove the option to unload a patient while being inside a vehicle. It kinda doesn't make much sense.

@jonpas
Copy link
Member

jonpas commented Sep 17, 2017

But you might have to get him out and into a medical vehicle for example, or a medical facility which you can't exactly drive into.

@jonpas jonpas added this to the 3.11.0 milestone Sep 17, 2017
@jonpas
Copy link
Member

jonpas commented Sep 17, 2017

Looks like finding unload position is failing. @PabstMirror ?

@bux
Copy link
Member

bux commented Sep 18, 2017

@jonpas unloading from outside would be used for that. From a realism pov that makes more sense

@jonpas
Copy link
Member

jonpas commented Sep 18, 2017

Ah, that's what you meant. Then yes, I agree.

@PabstMirror PabstMirror modified the milestones: 3.11.0, Medical Rewrite Sep 18, 2017
@Arcanum417
Copy link
Contributor Author

In master, you cannot unload if the caller is inside. With medical-rewrite, you cannot unload even if caller is outside, that was the original bug I wanted to report.

@Arcanum417
Copy link
Contributor Author

@jonpas
Copy link
Member

jonpas commented Sep 23, 2017

I "fixed" this on master as discussed above (by disabling unloading when inside vehicle, only from outside) in #5544. Will reopen this once PR gets merged because this is addressing medical-rewrite.

@PabstMirror
Copy link
Contributor

Problem is in ace_common_fnc_unloadpersonLocal
I think this is related to the setUnconscious command usage.
player action ["Eject", vehicle player]; has no effect

Even more bizarre is doing setPos on the unconscious unit
from uncon's prespective getPos and vehicle unit changes, but goes back to the vehicle after about 10 seconds
from the server's point of view the unit never left the vehicle.

Doing setPos on the server for the unit has global, permanent effects.

@jonpas
Copy link
Member

jonpas commented Sep 26, 2017

action not having effect kind of makes sense, since it's supposed to simulate the unit actually doing the action.

@PabstMirror
Copy link
Contributor

Should be fixed via 75e58a8

Will need more testing in mp, but seems to work
looks funny because of the ragdoll but also simplifies a lot of things

PabstMirror pushed a commit that referenced this issue Sep 27, 2017
* Disable (un)load patient action if unit is dead but was uncoscious before

* Remove handcuffs on death (prevents stand-up ragoll restart), Don't show load patient and captive at the same time

* Only allow unloading from outside - fix #5525 as discussed

* Also prevent unloading captives from inside

* Add debug logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants