Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class CBA_MiscItem_ItemInfo not backwards compatible to class ItemInfo #5673

Closed
Pergor opened this issue Oct 25, 2017 · 4 comments
Closed

class CBA_MiscItem_ItemInfo not backwards compatible to class ItemInfo #5673

Pergor opened this issue Oct 25, 2017 · 4 comments

Comments

@Pergor
Copy link

Pergor commented Oct 25, 2017

Arma 3 Version: current (stable)
CBA Version: 3.4.1.170912
ACE3 Version: 3.11.0

Mods:

- CBA_A3
- ace

Description:

  • ACE-compatible custom items are broken with missing backwards compatibility after switch to CBA_MiscItem. Don't know if it's something that ought to be mended or rather just something that ought to be made known to modders.

Steps to reproduce:

class cfgWeapons {
	class ACE_ItemCore;
	class InventoryItem_Base_F;
	
    class adv_aceCPR_AED: ACE_ItemCore {
        scope = 2;
        displayName = "Automated External Defibrillator";
        picture = "\adv_aceCPR\ui\defib.paa";
		model = "\A3\Structures_F_EPA\Items\Medical\Defibrillator_F.p3d";
        descriptionShort = "Use to resuscitate player";
        descriptionUse = "Use to resuscitate player";
        class ItemInfo: InventoryItem_Base_F {
            mass = 30;
        };
	};
};

Item can't be added to inventory any longer.

class cfgWeapons {
	class ACE_ItemCore;
	class CBA_MiscItem_ItemInfo;
	
    class adv_aceCPR_AED: ACE_ItemCore {
        scope = 2;
        displayName = "Automated External Defibrillator";
        picture = "\adv_aceCPR\ui\defib.paa";
		model = "\A3\Structures_F_EPA\Items\Medical\Defibrillator_F.p3d";
        descriptionShort = "Use to resuscitate player";
        descriptionUse = "Use to resuscitate player";
        class ItemInfo: CBA_MiscItem_ItemInfo {
            mass = 30;
        };
	};
};

Item works again.

@IrLED
Copy link

IrLED commented Oct 25, 2017

Many items became of type AccessoryBipod

diag_log format ["%1 -> %2", _x, _x call bis_fnc_itemtype];
}forEach ["ACE_EarPlugs","ACE_RangeCard","ACE_Clacker","ACE_M26_Clacker","ACE_DeadManSwitch","ACE_DefusalKit","ACE_MapTools","ACE_Flashlight_MX991","ACE_Sandbag_empty","ACE_wirecutter","ACE_RangeTable_82mm","ACE_EntrenchingTool","ACE_Cellphone","ACE_CableTie","ACE_SpottingScope","ACE_Tripod","ACE_fieldDressing","ACE_bloodIV_500","ACE_bloodIV","ACE_epinephrine","ACE_morphine","ACE_bodyBag"];

@jonpas
Copy link
Member

jonpas commented Oct 25, 2017

Yes, CBA_MiscItem is a bipod, a workaround to show them in Virtual Arsenal correctly. And yes, all mods should change it to use CBA_MiscItem_ItemInfo as well, ACE_ItemCore can be kept though.

yanek pushed a commit to 11rdp/modpack that referenced this issue Oct 30, 2017
After the 3.11.0 update, all items that inherits "InventoryItem_Base_F" are broken.
They should now use "CBA_MiscItem_ItemInfo". See acemod/ACE3#5673 for more info.
@stale
Copy link

stale bot commented Nov 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale label Nov 18, 2018
@jonpas
Copy link
Member

jonpas commented Nov 18, 2018

This was solved with other mods getting updated, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants