[Explosives] Self-Interaction Menu Breaking #7637

GCodeman · 2020-04-14T03:50:51Z

Mods

Arma 3: 1.96.146114
CBA: 3.15.0
ACE3: 3.13.1

Description:
After hovering your cursor over the Explosives portion of the ACE Self Interaction Menu then dying, the Explosives Tab will be permanently stuck with whatever options you had upon death. This persists regardless of dying again or dropping/gaining any explosives. Also, upon acquiring new explosives, the option to place them does not get added to your menu.

Steps to reproduce:
-Take any explosive
-Open self interaction menu and hover cursor over explosive, but do not place it
-Die in any fashion or press respawn from the menu

Expected behavior:
-Upon respawning, your explosives menu should reset but does not.

Where did the issue occur?

Self-Hosted Multiplayer (with several other players)
Editor (Hosted in multiplayer editor, but playing only by myself)

Video
https://www.youtube.com/watch?v=SfTBHNMH19g

The text was updated successfully, but these errors were encountered:

GCodeman · 2020-04-14T03:55:42Z

I just noticed that it also occurs when opening the self-interaction menu at all when an explosive is in your inventory, not just when hovering over an explosive.

bux · 2020-04-14T05:03:42Z

RPT is missing

GCodeman · 2020-04-14T22:29:57Z

ArmA updated to 1.98.146303 today, so I made a new RPT file.
https://pastebin.com/G7cEYt34

Whigital · 2020-04-18T13:53:58Z

Can confirm this, i think it has to do with how ACE_player reference changes when killed/respawned. Depending on when the cba_event_loadoutEvent is triggered, ace_common_fnc_eraseCache might clear the variables on the ragdoll, since the reference changed.

init.sqf

Report_Data = {
    params [
        "_event"
    ];

    _log = {
        params [
            "_cap",
            "_msg"
        ];

        diag_log (format ["%1: %2", _cap, _msg]);
    };

    private _cache = missionNamespace getVariable ["ace_common_clearCache_cba_events_loadoutEvent", nil];
    private _actions = ACE_player getVariable ["ace_explosives_explosiveActions", []];
    
    diag_log (format ["########## %1 ##########", _event]);
    diag_log (format ["player == %1", player]);
    diag_log (format ["ACE_player == %1", ACE_player]);
    ["ace_common_clearCache_cba_events_loadoutEvent", _cache] call _log;
    ["ace_explosives_explosiveActions", _actions] call _log;
};

if (hasInterface) then {
    // Loadout event tracker ....
    LoadoutEH = [
        "cba_events_loadoutEvent", {
            ["cba_events_loadoutEvent"] call Report_Data;
    }] call CBA_fnc_addEventHandler;

    // ACE death event tracker ....
    DeathEH = [
        "ace_medical_death", {
            ["ace_medical_death"] call Report_Data;

            // [ACE_player, "ace_explosives_explosiveActions"] call ace_common_fnc_eraseCache;
    }] call CBA_fnc_addEventHandler;

    // Respawn event tracker ....
    RespawnEH = (player addEventHandler [
        "Respawn", {
            ["Respawn"] call Report_Data;

            // [{[ACE_player, "ace_explosives_explosiveActions"] call ace_common_fnc_eraseCache;}, [], 1] call CBA_fnc_waitAndExecute;

            0 spawn {
                ["Pre-Cleared"] call Report_Data;
                diag_log "Waiting for 'ACE_player' to become 'player' ....";
                waitUntil {ACE_player == player};
                diag_log "Clearing ace_explosives_explosiveActions variable ....";
                [ACE_player, "ace_explosives_explosiveActions"] call ace_common_fnc_eraseCache;
                ["Cleared"] call Report_Data;
            };
        }]
    );

    // Killed event tracker ....
    KilledEH = (player addEventHandler [
        "Killed", {
            ["Killed"] call Report_Data;

            // [{[ACE_player, "ace_explosives_explosiveActions"] call ace_common_fnc_eraseCache;}, [], 1] call CBA_fnc_waitAndExecute;
        }]
    );
};

Logging output

23:45:55 "########## Killed ##########"
23:45:55 "player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ACE_player == 1a8dae21740# 8: b_soldier_01.p3d"
23:45:55 "ace_common_clearCache_cba_events_loadoutEvent: [[1a8dae21740# 8: b_soldier_01.p3d,""ace_dogtags_actionsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_tagging_checkRequiredItemsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_explosives_explosiveActions""]]"
23:45:55 "ace_explosives_explosiveActions: [3804.82,[[[""APERSMine_Range_Mag"",""VS-50 Anti-Personnel Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""APERSBoundingMine_Range_Mag"",""M26 Anti-Personnel Bounding Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_bouncing_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSBoundingMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""ClaymoreDirectionalMine_Remote_Mag"",""M18A1 Claymore (2)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_miniclaymore_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""ClaymoreDirectionalMine_Remote_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 
23:45:55 "########## Respawn ##########"
23:45:55 "player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ACE_player == 1a8dae21740# 8: b_soldier_01.p3d"
23:45:55 "ace_common_clearCache_cba_events_loadoutEvent: [[1a8dae21740# 8: b_soldier_01.p3d,""ace_dogtags_actionsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_tagging_checkRequiredItemsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_explosives_explosiveActions""]]"
23:45:55 "ace_explosives_explosiveActions: [3804.82,[[[""APERSMine_Range_Mag"",""VS-50 Anti-Personnel Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""APERSBoundingMine_Range_Mag"",""M26 Anti-Personnel Bounding Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_bouncing_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSBoundingMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""ClaymoreDirectionalMine_Remote_Mag"",""M18A1 Claymore (2)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_miniclaymore_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""ClaymoreDirectionalMine_Remote_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 
23:45:55 "########## cba_events_loadoutEvent ##########"
23:45:55 "player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ACE_player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ace_common_clearCache_cba_events_loadoutEvent: [[1a8dae21740# 8: b_soldier_01.p3d,""ace_dogtags_actionsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_tagging_checkRequiredItemsCache""],[1a8dae21740# 8: b_soldier_01.p3d,""ace_explosives_explosiveActions""]]"
23:45:55 "ace_explosives_explosiveActions: [3804.82,[[[""APERSMine_Range_Mag"",""VS-50 Anti-Personnel Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""APERSBoundingMine_Range_Mag"",""M26 Anti-Personnel Bounding Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_bouncing_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSBoundingMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""ClaymoreDirectionalMine_Remote_Mag"",""M18A1 Claymore (2)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_miniclaymore_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""ClaymoreDirectionalMine_Remote_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 
23:45:55 "########## Pre-Cleared ##########"
23:45:55 "player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ACE_player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ace_common_clearCache_cba_events_loadoutEvent: []"
23:45:55 "ace_explosives_explosiveActions: [3804.82,[[[""APERSMine_Range_Mag"",""VS-50 Anti-Personnel Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""APERSBoundingMine_Range_Mag"",""M26 Anti-Personnel Bounding Mine (3)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_bouncing_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""APERSBoundingMine_Range_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 8: b_soldier_01.p3d],[[""ClaymoreDirectionalMine_Remote_Mag"",""M18A1 Claymore (2)"",""\A3\Weapons_F\Data\UI\gear_mine_AP_miniclaymore_CA.paa"",{[{_this call ace_explosives_fnc_setupExplosive}, _this] call CBA_fnc_execNextFrame},{true},{},""ClaymoreDirectionalMine_Remote_Mag"",{[0, 0, 0]},2,[false,false,false,false,false],{}],[],1a8dae21740# 
23:45:55 "Waiting for 'ACE_player' to become 'player' ...."
23:45:55 "Clearing ace_explosives_explosiveActions variable ...."
23:45:55 "########## Cleared ##########"
23:45:55 "player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ACE_player == B Alpha 1-1:1 (PFC.Whigital)"
23:45:55 "ace_common_clearCache_cba_events_loadoutEvent: []"
23:45:55 "ace_explosives_explosiveActions: []"

Adding a waitUntil {ACE_player == player}; before calling ace_common_fnc_eraseCache seems to fix the issue.

GCodeman · 2020-04-19T08:38:16Z

Thanks a bunch for the workaround until this gets fixed! Cheers

Whigital · 2020-05-07T10:45:38Z

Shouldn't it be

} else {
    _cacheList pushBack [_namespace, _uid];
    missionNamespace setVariable [_varName, _cacheList];
};

at the end of this statement

ACE3/addons/common/functions/fnc_cachedCall.sqf

Lines 34 to 54 in 64de038

    
           if (isNil "_cacheList") then { 
        
               _cacheList = []; 
        
               missionNamespace setVariable [_varName, _cacheList]; 
        
               [_event, { 
        
                   #ifdef DEBUG_MODE_FULL 
        
                       INFO_1("Clear cached variables on event: %1",_eventName); 
        
                   #endif 
        
                   // Get the list of caches to clear 
        
                   //IGNORE_PRIVATE_WARNING ["_eventName"];  
        
                   // _eventName is defined on the function that calls the event 
        
                   private _varName = format [QGVAR(clearCache_%1), _eventName]; 
        
                   private _cacheList = missionNamespace getVariable [_varName, []]; 
        
                   // Erase all the cached results 
        
                   { 
        
                       _x call FUNC(eraseCache); 
        
                   } forEach _cacheList; 
        
                   // Empty the list 
        
                   missionNamespace setVariable [_varName, []]; 
        
               }] call CBA_fnc_addEventHandler; 
        
           };

since the missionNamespace var ("ace_common_clearCache_cba_events_loadoutEvent" in this case) never gets updated with the new _cachelist, if it exists ?

dedmen · 2020-05-07T15:20:39Z

Shouldn't it be

No? pushBack modifies by reference. And the reference already came from the misionNamespace variable.

Whigital · 2020-05-07T16:05:00Z

Thanks for the clarification, thought getVariable returned the value, not a reference.

…7637) (#7739) * respawn handler * Revert "respawn handler" This reverts commit abdf959. * unit switched eh Co-Authored-By: PabstMirror <pabstmirror@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>

mharis001 · 2020-06-13T23:52:37Z

Closing as fixed by #7739 .

GCodeman added the kind/bug label Apr 14, 2020

bux added status/need-more-info and removed kind/bug labels Apr 14, 2020

Whigital mentioned this issue May 28, 2020

Explosives - Fix place explosives cache not being cleared on respawn (#7637) #7739

Merged

mharis001 closed this as completed Jun 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Explosives] Self-Interaction Menu Breaking #7637

[Explosives] Self-Interaction Menu Breaking #7637

GCodeman commented Apr 14, 2020

GCodeman commented Apr 14, 2020

bux commented Apr 14, 2020

GCodeman commented Apr 14, 2020

Whigital commented Apr 18, 2020

GCodeman commented Apr 19, 2020

Whigital commented May 7, 2020

dedmen commented May 7, 2020

Whigital commented May 7, 2020

mharis001 commented Jun 13, 2020

[Explosives] Self-Interaction Menu Breaking #7637

[Explosives] Self-Interaction Menu Breaking #7637

Comments

GCodeman commented Apr 14, 2020

GCodeman commented Apr 14, 2020

bux commented Apr 14, 2020

GCodeman commented Apr 14, 2020

Whigital commented Apr 18, 2020

GCodeman commented Apr 19, 2020

Whigital commented May 7, 2020

dedmen commented May 7, 2020

Whigital commented May 7, 2020

mharis001 commented Jun 13, 2020