Hearing - Fix explosions not affecting hearing #10002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
May 27, 2024
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
reviewed
Jun 6, 2024
|
This needs more work. |
|
I'm happy with it as it is. I've tested modded arty too and it works well enough all round. |
LinkIsGrim
approved these changes
Aug 12, 2024
|
Tested in MP, LGTM |
johnb432
commented
Aug 12, 2024
Comment on lines
+95
to
+105
| addMissionEventHandler ["ProjectileCreated", { | ||
| params ["_projectile"]; | ||
|
|
||
| if (!local _projectile) exitWith {}; | ||
|
|
||
| // Rockets only explode on local clients | ||
| _projectile addEventHandler ["Explode", { | ||
| [QGVAR(explosion), _this] call CBA_fnc_globalEvent; | ||
| }]; | ||
| }]; | ||
|
|
There was a problem hiding this comment.
Can be moved to common, if the frag rewrite needs it.
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Have explosions affect hearing * Update fnc_explosion.sqf * Update XEH_postInit.sqf * Update addons/hearing/functions/fnc_explosion.sqf Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Update fnc_explosion.sqf * Make EH local * Use sound entry instead --------- Co-authored-by: PabstMirror <pabstmirror@gmail.com>
|
I'm sorry I can't create correct Issue now. It looks like after this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I have only done some testing with artillery shells and grenades, needs much more testing.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.