Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hearing - Code cleanup #10041

Merged
merged 6 commits into from
May 29, 2024
Merged

Hearing - Code cleanup #10041

merged 6 commits into from
May 29, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label May 28, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone May 28, 2024
LinkIsGrim
LinkIsGrim reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

addons/hearing/functions/fnc_updateVolume.sqf Show resolved Hide resolved
addons/hearing/functions/fnc_updateHearingProtection.sqf Show resolved Hide resolved
addons/hearing/functions/fnc_putInEarplugs.sqf Show resolved Hide resolved
addons/hearing/functions/fnc_removeEarplugs.sqf Show resolved Hide resolved
addons/hearing/functions/fnc_removeEarplugs.sqf Show resolved Hide resolved
@johnb432 johnb432 merged commit e535988 into master May 29, 2024
5 checks passed
@johnb432 johnb432 deleted the hearing-cleanup branch May 29, 2024 17:01
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@johnb432 @blake8090
Hearing - Code cleanup (acemod#10041)
65c962a 
* Hearing cleanup

* Update fnc_updateHearingProtection.sqf

* Fixes + tweaks

* Update initSettings.inc.sqf

* Update fnc_removeEarplugs.sqf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@johnb432 @LinkIsGrim