Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Improve addWeapon #10051

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Common - Improve addWeapon #10051

merged 1 commit into from
Jun 1, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jun 1, 2024

When merged this pull request will:

  • Adds 2 new parameters:
    • _removeLinkedItems controls the removal of linked items
    • _magazines allows the caller to define which magazines, along with ammo count, are inserted into the gun.
  • See Hit Reactions - Add weapon dropping on arm hit #9539 (review) (not even needed for that PR anymore).
    If magazines are passed the AI is prevented from reloading against our wishes.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Jun 1, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jun 1, 2024
@johnb432 johnb432 merged commit 99bb698 into master Jun 1, 2024
5 checks passed
@johnb432 johnb432 deleted the common-improve-addWeapon branch June 1, 2024 16:52
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants