Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat RF - Improve/Change RF Realistic Name #10071

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Jun 14, 2024

When merged this pull request will:

  • Add HEMMT Fire Truck localization (for Equalization with A3 realistic name)
  • Change Puma family naming and add missing variation
  • Change HADES(Hera H6) name to Uppercase

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Add HEMMT Fire Truck
Change Puma family naming and add missing variation
@Apricot-ale
Copy link
Contributor Author

Apricot-ale commented Jun 14, 2024

I would like to hear your opinion on this. Regarding the RAI-350/360, which is thought to be based on the IAR-330, I would like everyone to consider whether it should remain the H225 Puma, which has a similar shape, or whether it should be made into the IAR-330, which it is likely to be based on.

Import HEMTT Fire Truck localization from RF
Add "Container" to AMOS. cuz that is not just AMOS...
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have RF or the compat mod, so I can't weigh in properly, but I'm happy with the formatting. Name change from Hera to HERA also makes sense to me.

@Apricot-ale
Copy link
Contributor Author

I don't have RF or the compat mod, so I can't weigh in properly, but I'm happy with the formatting. Name change from to also makes sense to me.Hera``HERA

Thanks, and I'll one more change to this (AW159 thing)

For distinction with WY-55(Vanilla Wildcat) and AH-11F (RF Wildcat)
@Apricot-ale
Copy link
Contributor Author

I think it's ok

Does it really need? Probably not.
@PabstMirror PabstMirror added this to the 3.18.0 milestone Jun 20, 2024
@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label Jun 20, 2024
@PabstMirror PabstMirror merged commit 5ea202c into acemod:master Jun 20, 2024
5 checks passed
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Update RF Realname Stringtables

Add HEMMT Fire Truck
Change Puma family naming and add missing variation

* typo fix

* Tab to space I hate this

* Update stringtable.xml

Import HEMTT Fire Truck localization from RF
Add "Container" to AMOS. cuz that is not just AMOS...

* Uppercase and add rifle the HERA H6

* add space start of comment

* Add "ASW" to Wildcat AH-11F

For distinction with WY-55(Vanilla Wildcat) and AH-11F (RF Wildcat)

* Remove "Rifle" from H6

Does it really need? Probably not.
@Apricot-ale Apricot-ale deleted the UpdateRF-Jun24 branch November 15, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants