Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Add wheel hitpoint function #10075

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Common - Add wheel hitpoint function #10075

merged 2 commits into from
Jun 17, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Moves getWheelHitPointsWithSelections from repair to common, so that both repair and grenades can use the same function.
  • getWheelHitPointsWithSelections now uses caching.
  • draw_showRepairInfo no longer stack drawing icons when the game is paused.

TODO in another PR: getWheelHitPointsWithSelections doesn't work with numerous Global Mobilisation vehicles. For some reason the selections aren't reported and I can't understand why.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Jun 15, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jun 15, 2024
LinkIsGrim
LinkIsGrim approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnb432 johnb432 merged commit 4210710 into master Jun 17, 2024
5 checks passed
@johnb432 johnb432 deleted the common-wheel-selection-function branch June 17, 2024 17:31
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@johnb432 @blake8090
Common - Add wheel hitpoint function (acemod#10075)
e7fcfc1 
* Add wheel hitpoint function

* Moved cache to missionNamespace
Vdauphin added a commit to Vdauphin/HeartsAndMinds that referenced this pull request Oct 16, 2024
@Vdauphin
Change function name for wheel hit point
ec24932 
Since acemod/ACE3#10075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @PabstMirror @LinkIsGrim