Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Refactor target blood pressure #10081

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

Kexanone
Copy link
Member

When merged this pull request will:

  • Since blood volume below class III is always below class II, the condition is unnecessary.

_targetHR = DEFAULT_HEART_RATE;
if (_bloodVolume < BLOOD_VOLUME_CLASS_3_HEMORRHAGE) then {
private _targetBP = 107 * (_bloodVolume / DEFAULT_BLOOD_VOLUME);
Copy link
Contributor

@LinkIsGrim LinkIsGrim Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need the variable allocation at this point? Just #define TARGET_BP_CLASS_3_HEMORRHAGE 107 IMO

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Jun 19, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jun 19, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror PabstMirror merged commit c4fb858 into master Jun 20, 2024
5 checks passed
@PabstMirror PabstMirror deleted the Kexanone-patch-1 branch June 20, 2024 18:19
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants