Dogtags - Rename inventory items #10102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
reviewed
Jul 1, 2024
There was a problem hiding this comment.
IMO this should be a framework
There was a problem hiding this comment.
I agree, but frankly I don't want to invest the time and effort into making a framework. I saw the CBA one, but that seems to be stale.
There was a problem hiding this comment.
It was mostly done at the time iirc, just needs someone to wrap it up and make any changes that need to be accounted for
PabstMirror
reviewed
Jul 2, 2024
PabstMirror
reviewed
Jul 2, 2024
PabstMirror
reviewed
Jul 2, 2024
|
acre does something similar and struggles with flickering - IDI-Systems/acre2#1256 still fully usable with the ficker, but if we could find a solution it would be a benefit to both |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
|
Closed in favor of #10130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.