Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Improve AT/SLAM, Frag from Claymore and Bounding Mines #10105

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Jul 2, 2024

When merged this pull request will:

  • Reduce the trigger mass of the M15 AT Mine to a realistic value of the M603 pressure fuze:
    Previously it would only trigger at >7t, keeping Wiesel Tankettes (~4t) completely safe. Now it will detonate under any vehicle heavier (>300kg) than the vanilla quad bike (280kg).
  • Improve the M4 SLAM mine's damage dealt to soft and hard vehicles:
    Previously it wouldn't destroy cars and barely damage trucks (while killing the crew only in side-attack mode). Now it can reliably destroy them in both bottom and side-attacks and cook off tanks (40mm penetration is more than enough for MBT bottom armour).
    Had to change the fuse type from proximity to a 0.5m vertical "tripwire", in order to make them effective against moving vehicles. The purely "magnetic" proxy fuse would often trigger below a tank's cannon / right in front of its hull (especially at slow speed), dealing no damage.
    Implemented Editor and Zeus placed SLAM Bottom Attack Mines being pointed upwards, just like player-placed ones.
  • Make Claymore mines less destructive towards buildings while adding ACE Frag effects to compensate:
    Works well, front-facing lethality is not diminished, while added frag adds light injury potential when standing to the sides or rear (previously standing right behind it would deal no damage at all).
  • Enable Frag on APERS VS-50 and Bounding mines:
    Also reduced damage dealt by the Bounding mine to prevent it from insta-killing light vehicles from 20m away, lethality against infantry within 30m is unchanged.

@mrschick
Copy link
Contributor Author

mrschick commented Jul 2, 2024

@BrettMayson FYI, the duplicate class definition that I fixed with 581a62e was detected by the PR's pipeline and threw an error, but is not logged as an error by HEMTT v1.12.4.

@lambdatiger
Copy link
Contributor

lambdatiger commented Jul 17, 2024

Noticed you're basing your PR from this PR #9728. Sorry if I threw a wrench in any of your work, there were some issues with using init event handlers until we get getShotInfo. I fell back onto the old event driven system, but the final effect shouldn't differ. The changes you made to addons/frag/CfgAmmoFragParameters.hpp shouldn't conflict, but I thought I should give you a heads up that you might have to fight another merge conflict.

Also question, should your WIP claymore produce some of the 700 fragments spread in every direction, or just forward?

@mrschick
Copy link
Contributor Author

Thanks for the heads-up. Don't worry about it, I just need your excellent changes as a base to test explosive improvements, merge conflicts are only a minor hurdle while this PR is WIP anyway 👍🏻

My goal for the Claymore is to reduce its damage against buildings (without tweaking overall damage too much) and ideally get it to generate a realistic frag pattern, which includes a bit of shrapnel to its rear, since it has a rear danger zone of <1m right now.
Not completely sure how to set the gurney value to interact with explosionAngle to throw shrapnel mainly "forward" of the mine.

@mrschick mrschick force-pushed the feature/mine-improvements branch 2 times, most recently from c9ba906 to 9ae5509 Compare September 20, 2024 13:31
@mrschick mrschick changed the title Explosives - Improve AT, SLAM and Claymore Mines Explosives - Improve AT/SLAM, Frag from Claymore and Bounding Mines Sep 28, 2024
@mrschick mrschick marked this pull request as ready for review September 28, 2024 23:23
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** status/added-to-RC Added after RC, need to manually add to changelog labels Sep 30, 2024
@LinkIsGrim LinkIsGrim added this to the 3.18.0 milestone Sep 30, 2024
@LinkIsGrim LinkIsGrim merged commit 8d0e70a into acemod:master Sep 30, 2024
4 checks passed
@mrschick mrschick deleted the feature/mine-improvements branch September 30, 2024 09:34
@PabstMirror PabstMirror removed the status/added-to-RC Added after RC, need to manually add to changelog label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants