-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR Light - Fix bad item replacements and switching to primary weapons #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Jul 17, 2024
johnb432
commented
Jul 17, 2024
PabstMirror
reviewed
Jul 21, 2024
PabstMirror
reviewed
Jul 21, 2024
PabstMirror
approved these changes
Aug 8, 2024
- Added a weapon parameter to `switchAttachmentMode` - Made `switchPersistentLaser` take pointer switching into account - Fixed IR light attachments being added to the wrong weapon
|
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
…acemod#10119) * Fix bad item replacements and switching to primary weapons * Update addons/irlight/functions/fnc_initItemContextMenu.sqf * Update fnc_initItemContextMenu.sqf * Remove unused funtions * Various fixes/tweaks - Added a weapon parameter to `switchAttachmentMode` - Made `switchPersistentLaser` take pointer switching into account - Fixed IR light attachments being added to the wrong weapon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ace_common_fnc_switchAttachmentMode
#10135.switchAttachmentMode
(for last bullet point)switchPersistentLaser
take pointer switching into account (should have been added in Common - Improve persistent lights/lasers #10118, but overlooked)currentWeapon
, when it wasn't necessarily the unit's current weapon)Question I have:There are now 2 unused functions. Can we remove them?
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.