Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Move missing compats warning to pre start #10162

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Common - Move missing compats warning to pre start #10162

merged 3 commits into from
Aug 6, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 3, 2024

When merged this pull request will:

  • Title.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Aug 3, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 3, 2024
@LinkIsGrim
Copy link
Contributor

Not a fan. Even with conditional loading this seems like removing information for no reason.

@rautamiekka
Copy link
Contributor

Agree with @LinkIsGrim, this'll only cause problems.

@johnb432
Copy link
Contributor Author

johnb432 commented Aug 3, 2024

Not a fan. Even with conditional loading this seems like removing information for no reason.

The only information this provides is if you decide to use custom ACE repacks which don't include the compats for some reason, manually delete PBOs or if the addon name changes. In the first two, imo you are bound to know what you are doing and don't need a warning. In the last case, it would not load the addon because of the conditional loading.
Regardless, the message it provides contains an error, as the compats aren't part of the optionals anymore.

Agree with @LinkIsGrim, this'll only cause problems.

Problems such as?

@PabstMirror
Copy link
Contributor

PabstMirror commented Aug 4, 2024 •
edited
Loading

I'm fine with removal but maybe we could just move to pre-start so it only runs once?

@PabstMirror PabstMirror changed the title Advanced Ballistics - Remove missing compats warning Common - Move missing compats warning to pre start Aug 5, 2024
@johnb432 johnb432 merged commit 973cfdd into master Aug 6, 2024
5 checks passed
@johnb432 johnb432 deleted the advanced-ballistics-remove-compat-warnings branch August 6, 2024 07:48
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@johnb432 @PabstMirror @blake8090
Common - Move missing compats warning to pre start (acemod#10162)
242c308 
* Remove missing compats warning

* move to common/preStart

* ?

---------

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@johnb432 @LinkIsGrim @rautamiekka @PabstMirror