Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Rations - Various Usability Improvements #10171

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Aug 7, 2024

When merged this pull request will:

  • Add a 45s cooldown to thirst/hunger related loss of consciousness, to not require several tries before being able to complete the drinking/eating interaction.
  • Add water actions directly to vehicle instead of helper object if the vehicle has no custom "waterActionPosition":
    This was causing the helper object to be attached to the center of the vehicle, making the interaction almost impossible to access.
  • Add audio cues for high thirst/hunger, hearable by nearby players.
    Re-uses medical system "moan" sounds of increasing "intensity" and frequency as thirst/hunger increases beyond 70%.
  • Add the option for less punitive dehydration/starvation consequences, i.e: medical pain effects like loss of focus / chromatic aberration instead of going unconscious and/or dying.
    Currently the secondary option just adds normal medical pain, unsure on how to implement a separate pain effect option.
  • Make consumable items "magazines", so that they can have dynamic consumption and many more fill/integrity levels.
  • Maybe make advanced fatigue influence hunger/thirst increase, as opposed to the current linear multiplier tied to movement speed and hunger/thirst influencing fatigue.
  • Maybe add force-feeding interactions, ideally tied to CBA Setting.
  • Multiply saline rehydrating effect by inverse water consumption, to maintain effectiveness at reduced "time without water" settings.
  • A Compat with CUP "well" terrain objects.
  • Update Documentation.

@mrschick mrschick changed the title Feature/field ration improv Field Rations - Various Usability Improvements Aug 7, 2024
@Drofseh
Copy link
Contributor

Drofseh commented Aug 10, 2024

Make consumable items "magazines" will likely also require a rework of how the items are used in Overheating
https://github.com/acemod/ACE3/blob/master/addons/overheating/functions/fnc_coolWeaponWithItem.sqf

@mrschick
Copy link
Contributor Author

Yup.

There is also a limitation of water source actions, weapon cooling can't be done from inside of a vehicle because those actions are only added (like all WS actions before this PR) to a helper object that is attachedTo the custom "faucet" position on the vehicle.

Is there really a significant performance improvement to that method over just adding the interactions to all vehicle classes?
Alternatively, if the issue is the heap of static prop classes it would run on, could it just be config-added to Land and Air Vehicles, and continue generating helpers on all other vehicles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants