Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aegis Compat - Overwrite some Aegis changes #10173

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Aegis Compat - Overwrite some Aegis changes #10173

merged 2 commits into from
Aug 11, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 7, 2024

When merged this pull request will:

  • "Compat" is too strong of a term, the purpose of this is to only overwrite some changes Aegis makes, in order to fix the stuff that is currently broken when loading both Aegis and ACE.

I've added the "ignore-changelog" tag because I don't want people thinking this is an official ACE-Aegis compat, as atm it's only doing fixes. Personally I'm not planning on adding any compatibility, but I decided to add it for future use.
In order to drop the word "compat", the only alternative would be to add this into the vehicles addon directly.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** ignore-changelog Release Notes: Excluded labels Aug 7, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 7, 2024
@PabstMirror
Copy link
Contributor

We should put it in the patch notes so it's not a surprise to people

  • it might show up in requiredAddons in missions
  • the ace client/server mismatch errors that people get from running different mods from server

@johnb432
Copy link
Contributor Author

johnb432 commented Aug 8, 2024

We should put it in the patch notes so it's not a surprise to people

* it might show up in requiredAddons in missions

* the `ace client/server mismatch` errors that people get from running different mods from server

Would adding

// this prevents any patched class from requiring this addon
addonRootClass = "A3_Characters_F";
remove the requiredAddons problem?

@johnb432
Copy link
Contributor Author

johnb432 commented Aug 8, 2024

I haven't been able to make it create a dependency (I just placed down both variants of the Merkava in the editor - I'm not sure if you can do anything else).

@PabstMirror
Copy link
Contributor

We never had any luck getting addonRootClass to work
but it's great if it's not creating dependency

I'd still like it in changelog for the mismatch errors people seem to always get but it's fine either way

@johnb432 johnb432 added kind/feature Release Notes: **ADDED:** and removed ignore-changelog Release Notes: Excluded kind/enhancement Release Notes: **IMPROVED:** labels Aug 11, 2024
@johnb432 johnb432 merged commit 70c8322 into master Aug 11, 2024
5 checks passed
@johnb432 johnb432 deleted the aegis-compat branch August 11, 2024 15:10
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Overwrite some Aegis changes

* Preemptively overwrite upcoming changes to Aegis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants