Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Use triggerAmmo instead of setDamage #10182

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 10, 2024

When merged this pull request will:

  • Title.
  • This would allow explosives that can't be triggered by damage to exist. The APERS mine dispenser is one of those with these changes.
    Do we want the APERS mine dispenser not to explode when destroyed?

TODO:

  • Test in MP (if triggerAmmo needs to be local) - needs to be local
  • Test if setShotParents/getShotParents still works - tested with a dedicated server and everything works as expected.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 10, 2024
@johnb432 johnb432 marked this pull request as ready for review August 10, 2024 17:48
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 10, 2024
@LinkIsGrim
Copy link
Contributor

Do we want the APERS mine dispenser not to explode when destroyed?

Only if it's empty potentially?

@johnb432
Copy link
Contributor Author

johnb432 commented Aug 12, 2024

Only if it's empty potentially?

APERS mine dispenser can't be empty, When it's triggered, it creates the submunitions and deletes the dispenser.

@johnb432
Copy link
Contributor Author

I'll make another PR for making the APERS mine dispenser trigger when destroyed, as to keep things separate.

@johnb432 johnb432 merged commit f3938ba into master Aug 12, 2024
5 checks passed
@johnb432 johnb432 deleted the explosives-use-triggerAmmo branch August 12, 2024 13:18
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Use `triggerAmmo` instead of `setDamage`

* Update docs/wiki/framework/explosives-framework.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants