Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Add replacement items for editor inventory management #10216

Merged
merged 1 commit into from
Aug 22, 2024
Merged

General - Add replacement items for editor inventory management #10216

merged 1 commit into from
Aug 22, 2024
+45 −6

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Fixes painkillers, notepad and spare barrel not being available in the "equipment storage" attribute in the editor.
  • It's either this (or some variant of item replacement) or we rewrite the attribute's function to accommodate.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Aug 17, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 17, 2024
PabstMirror
PabstMirror approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary evil i guess 😄

LinkIsGrim
LinkIsGrim approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to document need of this? (Not sure where, though)

@PabstMirror PabstMirror merged commit 1dae884 into master Aug 22, 2024
5 checks passed
@PabstMirror PabstMirror deleted the general-add-replacement-items branch August 22, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @PabstMirror @LinkIsGrim