Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS Compat - Add interaction anims to WS vehicles #10229

Merged
merged 1 commit into from
Aug 22, 2024
Merged

WS Compat - Add interaction anims to WS vehicles #10229

merged 1 commit into from
Aug 22, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Adds Interaction - Add actions based on animations #6144 to WS vehicles.
  • Improves backpack interaction anims position on the offroad variants, but at the cost of losing inheritance for the anims. I'll gladly take someone's solution for not breaking inheritance for anims, I'm too stupid for this type of inheritance structure.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 19, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 19, 2024
PabstMirror
PabstMirror approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have dlc to test, but configs look good

@rautamiekka
Copy link
Contributor

don't have dlc to test, but configs look good

https://steamcommunity.com/sharedfiles/filedetails/?id=2636962953

@johnb432 johnb432 changed the title Compat WS - Add interaction anims to WS vehicles WS Compat - Add interaction anims to WS vehicles Aug 21, 2024
@LinkIsGrim LinkIsGrim merged commit abced51 into master Aug 22, 2024
4 checks passed
@LinkIsGrim LinkIsGrim deleted the compat-ws-interaction-anims branch August 22, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@johnb432 @rautamiekka @PabstMirror @LinkIsGrim