Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magazine Repack - Add ability to disable repacking via class #10232

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Aug 19, 2024

When merged this pull request will:

  • Adds optional ability to disable magazine repacking by CfgMagazines entry.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@Mike-MF
Copy link
Member Author

Mike-MF commented Aug 19, 2024

Someone should look at the documentation, No idea if I did it right or not for a new file.

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a specific use case in mind? Atm I can't really see any, I would be happy to learn about the scenarios where you'd want/need to use this.

@Mike-MF
Copy link
Member Author

Mike-MF commented Aug 19, 2024

Do you have a specific use case in mind? Atm I can't really see any, I would be happy to learn about the scenarios where you'd want/need to use this.

Any item you track the count of that you wouldn't be able to "repack", for example Brett mentioned that you can repack UAV batteries which .. probably shouldn't work.

Survival mods/scenarios that utilise ACE would also benefit from this.

@MiszczuZPolski
Copy link
Contributor

MiszczuZPolski commented Aug 19, 2024

Do you have a specific use case in mind? Atm I can't really see any, I would be happy to learn about the scenarios where you'd want/need to use this.

I guess you can also use it to disable repacking ACE_Painkillers?

@Mike-MF
Copy link
Member Author

Mike-MF commented Aug 19, 2024

you can, but painkillers actually makes sense as it's a pill bottle, just pour one into the other and ignore the bullet clicky sounds.

@MiszczuZPolski
Copy link
Contributor

you can, but painkillers actually makes sense as it's a pill bottle, just pour one into the other and ignore the bullet clicky sounds.

yet model is pill box 🦘 tho i already see use case for this in KAM

@rautamiekka
Copy link
Contributor

repack UAV batteries

And even if you had a small enough portable charger to transfer the energy between the batteries, it'd take far too long to be of any use (something like 1-4 hours (I think) when the battery is like 15-30%), which'd break any resemblance of realism.

you can, but painkillers actually makes sense as it's a pill bottle, just pour one into the other and ignore the bullet clicky sounds.

yet model is pill box 🦘 tho i already see use case for this in KAM

I doubt the pills would be loose in the box, instead in some kinda holders.

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Aug 20, 2024
@jonpas jonpas added this to the 3.18.0 milestone Aug 20, 2024
@jonpas
Copy link
Member

jonpas commented Aug 20, 2024

I doubt the pills would be loose in the box, instead in some kinda holders.

They do come loose in the box in the US.

@PabstMirror PabstMirror merged commit 52c19d5 into master Aug 20, 2024
4 checks passed
@PabstMirror PabstMirror deleted the magrepack-disableviaclass branch August 20, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants