Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Use animateSource instead of animate for interaction anims #10249

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** ignore-changelog Release Notes: Excluded labels Aug 24, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 24, 2024
@johnb432 johnb432 changed the title Interaction - Use ´animateSource´ instead of ´animate´ for interaction anims Interaction - Use animateSource instead of animate for interaction anims Aug 24, 2024
@PabstMirror
Copy link
Contributor

I was wondering about using that cmd but the biki says

If animate uses class name from CfgModels Animations, animateSource uses name defined by the source property.

made me think the names would be different? but maybe I'm just not reading that right
obviously if it works then it's not a problem

@PabstMirror PabstMirror self-requested a review August 24, 2024 14:40
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in mp

@PabstMirror PabstMirror merged commit 008606f into master Aug 24, 2024
4 checks passed
@PabstMirror PabstMirror deleted the interaction-use-animateSource branch August 24, 2024 23:59
johnb432 added a commit that referenced this pull request Sep 23, 2024
johnb432 added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants