Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Make FUNC(getVehicleIcon) check for strings without the .paa extension #10257

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Aug 25, 2024

When merged this pull request will:

  • Suggests a possible fix when the ".paa" extension is not included*.
    • This specifically would fix GM's vehicle icons not being retrieved.

* Apparently the ".paa" on a vehicle's icon config entry is optional.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@lambdatiger lambdatiger marked this pull request as ready for review August 25, 2024 02:47
@lambdatiger
Copy link
Contributor Author

The only issue with doing the fileExists check is that if an odd string is stored in icon such as "\a", it fileExits for "\a.paa" takes 20x longer to run (~100 µs for me), which might be too much overhead on a utility function.

@lambdatiger lambdatiger changed the title Common - update getVehicleIcon icon to check for strings without the .paa extension Common - update getVehicleIcon to check for strings without the .paa extension Aug 25, 2024
@johnb432 johnb432 changed the title Common - update getVehicleIcon to check for strings without the .paa extension Common - Make FUNC(getVehicleIcon) check for strings without the .paa extension Aug 25, 2024
@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 25, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 25, 2024
Update addons/common/functions/fnc_getVehicleIcon.sqf

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@PabstMirror PabstMirror merged commit da73cf9 into acemod:master Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants