Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Add remote squad management #10258

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Interaction - Add remote squad management #10258

merged 4 commits into from
Aug 27, 2024

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Aug 25, 2024

Idea from @Drofseh

image

@PabstMirror PabstMirror added the kind/feature Release Notes: **ADDED:** label Aug 25, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 25, 2024
@Drofseh
Copy link
Contributor

Drofseh commented Aug 25, 2024

I think Assign White would be better than Leave Team.
Leave Team could be intepreted as removing them from the group rather than removing their colour.

@johnb432
Copy link
Contributor

I think Assign White would be better than Leave Team. Leave Team could be intepreted as removing them from the group rather than removing their colour.

Leave team is what's currently in use in the team management interactions. However, I do agree, it would be better to update both to Assign White, it's less confusing that way.

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could assignedTeam returning "" be problematic?
From what I can gather it seems like all functions in which it could be problematic have already have measures in place to deal with it.

addons/interaction/functions/fnc_joinTeam.sqf Outdated Show resolved Hide resolved
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@PabstMirror
Copy link
Contributor Author

https://community.bistudio.com/wiki/assignedTeam
It used to give nil which caused problems

String (or, prior to Arma 3 v1.94, Nothing if given unit is objNull or remoteControlling another unit)

But I think just getting "" should be ok

@LinkIsGrim LinkIsGrim merged commit 884ae78 into master Aug 27, 2024
4 checks passed
@PabstMirror PabstMirror deleted the replaceSquadDrop branch August 27, 2024 21:30
class ACE_remoteTeamManagement {
displayName = CSTRING(Squad);
icon = QPATHTOF(UI\team\team_management_ca.paa);
condition = QUOTE(GVAR(remoteTeamManagement));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have (_unit == leader _unit)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants