New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Fix dragging breaking via keybind #10261

Merged

LinkIsGrim merged 1 commit into master from dragging-fix-dragging

Aug 27, 2024

Contributor

johnb432 commented Aug 25, 2024

When merged this pull request will:

Previously, if you double tapped the dragging keybind, it would fail to release the claim on the dragged object. This PR fixes that.
Stopped setting variables unnecessarily. I'm a little afraid of race condition bs that could happen.
Use local _target variable, instead of getting QGVAR(draggedObject). Imo the updated version is safer, because QGVAR(draggedObject) could be changed for some reason.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.


          Fixed dragging breaking via keybind

0199e58

johnb432 added the kind/bug-fix label

johnb432 added this to the 3.18.0 milestone

LinkIsGrim approved these changes

View reviewed changes

PabstMirror approved these changes

View reviewed changes

LinkIsGrim merged commit 3b10396 into master

4 checks passed

LinkIsGrim deleted the dragging-fix-dragging branch

August 27, 2024 04:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels