Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Handle turret locality safer #10272

Merged
merged 4 commits into from
Aug 30, 2024
Merged

CSW - Handle turret locality safer #10272

merged 4 commits into from
Aug 30, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 29, 2024

When merged this pull request will:

  • Title.
  • FUNC(initVehicle): Nothing guarantees that the CSW will still be local in the next frame, so better to see if CSW is local in the next frame. Addressed in CSW - Improve "disableWeaponAssembly" status effect usage #10273, by removing the delay by a frame.
  • FUNC(proxyWeapon): Both calls to it (with the change above) check if the turret is local and quit if it isn't, so it should be fine. My worry is if it's called from a 3rd party, but idk how likely that is, so I'm unsure how needed this change is.
  • FUNC(staticWeaponInit_unloadExtraMags): Removes magazines from all turrets, a frame after the vehicle has been initialised, which technically leaves some time for a unit to be moved into a turret, which could force a locality switch if said unit is remote.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 29, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 29, 2024
johnb432 and others added 2 commits August 30, 2024 05:38
@johnb432 johnb432 merged commit f0ae2c5 into master Aug 30, 2024
4 checks passed
@johnb432 johnb432 deleted the csw-handle-locality-safer branch August 30, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants