Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat RF - Field Rations - Watersource Offsets #10282

Merged
merged 16 commits into from
Sep 8, 2024

Conversation

OverlordZorn
Copy link
Contributor

@OverlordZorn OverlordZorn commented Sep 1, 2024

Adds config properties for reaction forces vehicles which can carry drinking water.

107410_20240901200514_1
107410_20240901190709_1
107410_20240901200633_1

@OverlordZorn
Copy link
Contributor Author

107410_20240901195108_1
For the Typhoon Water Carrier, i have an optional alternative which is a hatch on the right side, as this would make more sense instead of just in the rear, but:

  • this hatch might be for the fuel tank of the vehicle.
  • having the accesspoint rear-center might be more intuitive for a normal user.

@OverlordZorn OverlordZorn marked this pull request as ready for review September 1, 2024 18:10
Copy link
Contributor

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching over to ACEX macros. I think I got it right.

addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
@OverlordZorn
Copy link
Contributor Author

OverlordZorn commented Sep 1, 2024

Switching over to ACEX macros. I think I got it right.

If this would be inside the ACEX Field_Rations Addon itself, it would work. but its inside the compat_rf addon.
The macro would resolve to acex_compat_rf_offset, so this would not work.

you would need to use EXGVAR(var1,var2) as in EXGVAR(field_ration,offset)

EXGVAR(field_rations,offset)[] = {-0.13, 0, 0.2};

OverlordZorn and others added 4 commits September 3, 2024 20:48
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
OverlordZorn and others added 2 commits September 6, 2024 22:06
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
@Mike-MF Mike-MF added this to the 3.18.0 milestone Sep 6, 2024
@Mike-MF Mike-MF added the kind/enhancement Release Notes: **IMPROVED:** label Sep 6, 2024
@Mike-MF Mike-MF changed the title Compat - Reaction Forces - Field Rations - Watersource Offsets Compat RF - Field Rations - Watersource Offsets Sep 6, 2024
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/compat_rf/CfgVehicles.hpp Outdated Show resolved Hide resolved
OverlordZorn and others added 2 commits September 8, 2024 22:45
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@PabstMirror PabstMirror merged commit 36b9835 into acemod:master Sep 8, 2024
4 checks passed
@OverlordZorn OverlordZorn deleted the zrn-rf-compat-water-source branch October 29, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants