Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortify - Add item/weapon/backpack fortify tool property #10290

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

DartRuffian
Copy link
Contributor

When merged this pull request will:

  • Title

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Contributor Author

Implementation is essentially the same as trenches' entrenching tool. Cache on preStart, assign global var on preInit

@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 3, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Sep 3, 2024
@DartRuffian
Copy link
Contributor Author

DartRuffian commented Sep 3, 2024

@PabstMirror Do you want me to update trenches to do the same thing with compileFinal? I can add it to here or just make a separate PR, but feels like a really small change.

@PabstMirror
Copy link
Contributor

I don't know if it really matters,
but hashes seem like they are a more native way to store protected data instead of compiling code

@DartRuffian
Copy link
Contributor Author

Fair point
Honestly I don't even see a need to compile it anyway. It could just be saved to an array and then to a global variable in preInit

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim changed the title Fortify - Add ability for any item, weapon, or backpack to be a fortify tool Fortify - Add item/weapon/backpack fortify tool property Sep 5, 2024
@LinkIsGrim LinkIsGrim merged commit 2f72c77 into acemod:master Sep 5, 2024
4 checks passed
@DartRuffian DartRuffian deleted the fortify/tool-property branch September 23, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants