Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Fix some undefined variables #10335

Merged
merged 3 commits into from
Sep 28, 2024
Merged

General - Fix some undefined variables #10335

merged 3 commits into from
Sep 28, 2024

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** status/added-to-RC Added after RC, need to manually add to changelog labels Sep 24, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 24, 2024
@PabstMirror
Copy link
Contributor Author

I know all the //IGNORE stuff is a little obnoxious, but I think it's worth it to help find errors

@LinkIsGrim
Copy link
Contributor

Some

77 files changed

Oh boy.

@PabstMirror
Copy link
Contributor Author

Should I rip out the real changes to other prs and leave the annotations separate?

@johnb432
Copy link
Contributor

Should I rip out the real changes to other prs and leave the annotations separate?

Imo no.

@PabstMirror PabstMirror merged commit 1efe823 into master Sep 28, 2024
4 checks passed
@PabstMirror PabstMirror deleted the inspector1 branch September 28, 2024 00:03
@PabstMirror PabstMirror removed the status/added-to-RC Added after RC, need to manually add to changelog label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @LinkIsGrim @johnb432