-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - Add setting to use limb damage for sum of trauma #10362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Russian translations for new keys
Co-authored-by: Smith <smitt14ua@gmail.com>
Looks like very useful PR for me. Sum of trauma is the most general reason of deaths and we have many complains about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than comments
I'd like for the lazy points to be addressed before this is merged (I'd also like to not address them myself) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smitt14ua can you update translations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Russian translations
Co-authored-by: Smith <smitt14ua@gmail.com>
When merged this pull request will:
Implementation is a bit lazy:
Damage threshold is per-limb because configuring this as a user is a nightmare otherwise. Default is pretty generous to compensate for lack of armor in the limbs of most units.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.