Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add setting to use limb damage for sum of trauma #10362

Merged
merged 8 commits into from
Nov 3, 2024

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Oct 5, 2024

When merged this pull request will:

  • Title.
  • Cleanup unused vars in handleIncapacitation.

Implementation is a bit lazy:

  • You can't set limb DT per-unit (would be neat?)

Damage threshold is per-limb because configuring this as a user is a nightmare otherwise. Default is pretty generous to compensate for lack of armor in the limbs of most units.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Contributor

@smitt14ua smitt14ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Russian translations for new keys

addons/medical_damage/stringtable.xml Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
addons/medical_damage/stringtable.xml Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
Co-authored-by: Smith <smitt14ua@gmail.com>
@smitt14ua
Copy link
Contributor

Looks like very useful PR for me. Sum of trauma is the most general reason of deaths and we have many complains about it

@johnb432 johnb432 self-requested a review October 14, 2024 06:17
@johnb432 johnb432 added the kind/feature Release Notes: **ADDED:** label Oct 19, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 19, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than comments

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim
Copy link
Contributor Author

I'd like for the lazy points to be addressed before this is merged (I'd also like to not address them myself)

Copy link
Contributor Author

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smitt14ua can you update translations?

Copy link
Contributor

@smitt14ua smitt14ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Russian translations

addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
Co-authored-by: Smith <smitt14ua@gmail.com>
@LinkIsGrim LinkIsGrim merged commit b153310 into master Nov 3, 2024
3 checks passed
@LinkIsGrim LinkIsGrim deleted the medical-limb-sumoftrauma branch November 3, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants