Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Add private and remove some unused vars #10371

Merged
merged 7 commits into from
Oct 21, 2024
Merged

General - Add private and remove some unused vars #10371

merged 7 commits into from
Oct 21, 2024

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Oct 8, 2024
@PabstMirror PabstMirror added this to the 3.18.1 milestone Oct 8, 2024
@PabstMirror PabstMirror modified the milestones: 3.18.1, 3.18.2 Oct 9, 2024
johnb432
johnb432 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from https://github.com/acemod/ACE3/pull/10371/files#r1802402512, LGTM

@PabstMirror PabstMirror merged commit d7c8460 into master Oct 21, 2024
3 checks passed
@PabstMirror PabstMirror deleted the privateUnused branch October 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenLuke LorenLuke LorenLuke left review comments

@TheCandianVendingMachine TheCandianVendingMachine TheCandianVendingMachine left review comments

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @TheCandianVendingMachine @LorenLuke @johnb432