Overpressure - Add editor range attribute for vehicles #10411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: doesnt work yet
it works fine now
LinkIsGrim
changed the title
|
Why are all the tabs failing OH MY GOD |
|
TODO:
|
LinkIsGrim
changed the title
LinkIsGrim
reviewed
Oct 13, 2024
LinkIsGrim
reviewed
Oct 13, 2024
|
Okay, I fixed EVERYTHING - This PR is ready for review & merge. |
LinkIsGrim
reviewed
Oct 13, 2024
LinkIsGrim
reviewed
Oct 13, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
reviewed
Oct 13, 2024
LinkIsGrim
reviewed
Oct 13, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
previously approved these changes
Oct 13, 2024
PabstMirror
reviewed
Oct 13, 2024
| private _unitOverpressureRangeAttribute = _unit getVariable QEGVAR(overpressure,distance); | ||
|
|
||
| // If -1 (disabled) we return to server value, otherwise we use the given value. | ||
| _dangerZoneRange = _dangerZoneRange * [_unitOverpressureRangeAttribute, GVAR(overpressureDistanceCoefficient)] select (_unitOverpressureRangeAttribute < 0); |
There was a problem hiding this comment.
help[L-S12]: Invalid Args - [B:*]
┌─ addons/overpressure/functions/fnc_firedEHOP.sqf:29:37
you are multiplying a number times an array
PabstMirror
reviewed
Oct 13, 2024
| @@ -22,7 +22,11 @@ TRACE_8("firedEH:",_unit,_weapon,_muzzle,_mode,_ammo,_magazine,_projectile,_gunn | |||
| private _opValues = [_weapon, _ammo, _magazine] call FUNC(getOverPressureValues); | |||
|
|
|||
| _opValues params ["_dangerZoneAngle", "_dangerZoneRange", "_dangerZoneDamage"]; | |||
| _dangerZoneRange = _dangerZoneRange * GVAR(overpressureDistanceCoefficient); | |||
|
|
|||
| private _unitOverpressureRangeAttribute = _unit getVariable QEGVAR(overpressure,distance); | |||
There was a problem hiding this comment.
this will be undefined for most cases
There was a problem hiding this comment.
Shouldn't the editor attribute set it to -1 because of default value?
There was a problem hiding this comment.
Suggested change
| private _unitOverpressureRangeAttribute = _unit getVariable QEGVAR(overpressure,distance); | |
| private _unitOverpressureRangeAttribute = _unit getVariable [QEGVAR(overpressure,distance), -1]; |
in any case
LinkIsGrim
reviewed
Oct 13, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
PabstMirror
reviewed
Oct 16, 2024
PabstMirror
reviewed
Oct 16, 2024
PabstMirror
reviewed
Oct 16, 2024
johnb432
reviewed
Oct 19, 2024
Signed-off-by: bluefield <59333909+bluefieldcreator@users.noreply.github.com>
Signed-off-by: bluefield <59333909+bluefieldcreator@users.noreply.github.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Signed-off-by: bluefield <59333909+bluefieldcreator@users.noreply.github.com>
|
I think... that's it... I hate the GH phone app, I thought it merged your changes. My bad |
PabstMirror
reviewed
Oct 20, 2024
PabstMirror
approved these changes
Oct 20, 2024
Signed-off-by: bluefield <59333909+bluefieldcreator@users.noreply.github.com>
PabstMirror
approved these changes
Oct 20, 2024
|
Finally... :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Problem: if the user has the server setting set to 10 (example) and a mission maker wants to set a vehicle's value to 0, it wont work. Since we check for >= 0.1I cant figure out a good system other than making an entire new overpressure setting called "enable overpressure" as a checkbox instead of the range slider.There might be some use cases where a user may want to disable overpressure on some vehicles, and change the values of others, which would require both... so I might update this in the future to add such use case.Important bits of code: cfgEden.hpp & fnc_firedEHOP.sqf
2nd ever PR i appreciate all feedback. 🥲
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.