Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goggles - Add individual files for config classes #10420

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Goggles - Add individual files for config classes #10420

merged 6 commits into from
Oct 19, 2024

Conversation

DartRuffian
Copy link
Contributor

@DartRuffian DartRuffian commented Oct 15, 2024 •
edited
Loading

When merged this pull request will:

  • Move root classes from config.cpp to each of their own *.hpp files..
  • Move macros to a script_macros.hpp file.
    • Some of these might make more sense in a defines.hpp
  • Add IDD / IDC macros for dialogs and controls.

No functionality was changed, just organization.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Contributor Author

DartRuffian commented Oct 15, 2024 •
edited
Loading

I got annoyed when looking at things in goggles, so I wanted to PR moving stuff to their own files

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Oct 15, 2024
@PabstMirror PabstMirror added this to the 3.18.2 milestone Oct 15, 2024
@DartRuffian
Copy link
Contributor Author

DartRuffian commented Oct 15, 2024 •
edited
Loading

Should the goggles changes in compat_spe be moved to its own addon and include the goggles\script_macros.hpp?

@Mike-MF
Copy link
Member

Mike-MF commented Oct 16, 2024

Should the goggles changes in compat_spe be moved to its own addon and include the goggles\script_macros.hpp?

Forgot to respond to this, It was said somewhere, either on here or Discord that turning goggles into subaddons wasn't desired.

@johnb432 johnb432 merged commit 9497cc7 into acemod:master Oct 19, 2024
3 checks passed
@DartRuffian DartRuffian deleted the goggles/cleanup branch October 26, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 approved these changes

@Mike-MF Mike-MF Mike-MF approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
4 participants
@DartRuffian @Mike-MF @PabstMirror @johnb432