Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Sort stringtable entries alphabetically #10438

Closed
wants to merge 2 commits into from

Conversation

johnb432
Copy link
Contributor

Tool removes comments, so the handful of comments there were have been removed.

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Tool removes comments, so the handful of comments there were have been removed.
@johnb432 johnb432 added ignore-changelog Release Notes: Excluded kind/cleanup Release Notes: **CHANGED:** labels Oct 19, 2024
@@ -1,109 +1,109 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version='1.0' encoding='utf-8'?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes in header is fine for the spec but I tested tabler and it will rewrite to double on save

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look into it too hard, but xml.etree.ElementTree rewrites them automatically into single quotes.

@PabstMirror
Copy link
Contributor

ref BrettMayson/HEMTT#810

python does english and then languages in alphabetical,
hemtt seems to do english and then the wiki order
(english, czech, french..)

I don't care what order we use, but I'd like for them to be the same

@BrettMayson
Copy link
Member

Do we need this Python script still? Like mentioned in the other PR, I was planning on creating a PR to remove them.

Most can be replaced by a HEMTT script, or are just no longer needed

@johnb432
Copy link
Contributor Author

Do we need this Python script still?

Doesn't look like it.

I don't care what order we use, but I'd like for them to be the same

Might as well use the hemtt tool if it does it just as good if not better.


I'm going to close this PR, so that a new one can be made once HEMTT's localisation tool has been released.

@johnb432 johnb432 closed this Oct 21, 2024
@johnb432 johnb432 deleted the general-sort-stringtables branch October 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants