-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common - Improve file checking error messages #10448
Conversation
imo the fix should come first. users won't read the full error message, and we can maybe filter out more bogus issues if the order is changed |
4303583
to
d5f8be2
Compare
Had to unbreak git, no changes made in force push |
private _errorBuilder = switch (true) do { | ||
case _versionMismatch: {_fnc_diagnose_versionMismatch}; | ||
case _addonMismatch: {_fnc_diagnose_addonMismatch}; | ||
}; | ||
(call _errorBuilder) params ["_title", "_reasonMsg", "_fixMsg", "_infoMsg", "_infoMsgLog"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a possibility
private _errorBuilder = switch (true) do { | |
case _versionMismatch: {_fnc_diagnose_versionMismatch}; | |
case _addonMismatch: {_fnc_diagnose_addonMismatch}; | |
}; | |
(call _errorBuilder) params ["_title", "_reasonMsg", "_fixMsg", "_infoMsg", "_infoMsgLog"]; | |
(switch (true) do { | |
case _versionMismatch: _fnc_diagnose_versionMismatch; | |
case _addonMismatch: _fnc_diagnose_addonMismatch; | |
}) params ["_title", "_reasonMsg", "_fixMsg", "_infoMsg", "_infoMsgLog"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the biggest fan of it
I've asked two unrelated test subjects who don't even play Arma to take a look and they said it seems good and could probably fix it themselves (at least better than the old ones). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a logic point of view, LGTM
When merged this pull request will:
Example formatting:
Cases for errors are:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.