Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Rations - Add setting to disable in Zeus #10462

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

DartRuffian
Copy link
Contributor

@DartRuffian DartRuffian commented Oct 30, 2024

When merged this pull request will:

  • Add a new setting to disable hunger and thirst updates for players in Zeus.
  • Add a status effect for third party mods to disable hunger and thirst updates.
    • The internals come off as weird, since the event name becomes ace_common_field_rations_blockUpdates, but I felt a status effect would be the best implementation for third party mods.
    • Will update documentation if/when this is okay'd
  • Fix some small typos in the status effect functions.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Contributor Author

I would have sorted the stringtable entries however it seems like none of them have been sorted, so there would be an extra 130+ changed files. Would also potentially cause merge conflicts with other PRs.

@DartRuffian
Copy link
Contributor Author

DartRuffian commented Oct 31, 2024

I'll update the effect name here once #10468 is merged, or the other way around if this is merged first for whatever reason.

A different approach is being implemented

@DartRuffian DartRuffian force-pushed the field_rations/disable-update branch from 2b4b95f to 3a4ff93 Compare November 15, 2024 14:15
@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Nov 16, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Nov 16, 2024
@DartRuffian
Copy link
Contributor Author

Also shouldn't this get kind/setting as well?

@LinkIsGrim LinkIsGrim added the kind/setting Release Notes: **SETTINGS:** label Nov 16, 2024
@johnb432
Copy link
Contributor

johnb432 commented Nov 17, 2024

Also shouldn't this get kind/setting as well?

pic

The labels are used for the release notes and if we choose multiple, the same PR will appear multiple times in the release notes.

... or has that changed without my knowing?

@LinkIsGrim
Copy link
Contributor

Doesn't matter if it shows up twice as long as it's under SETTINGS: and something else. Ideally we'd list changes manually IMO, but I only had patience to do that exactly once (think it was 3.16.0?)

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim changed the title Field Rations - Add setting to disable hunger and thirst updates in Zeus, also add Status Effect Field Rations - Add setting to disable in Zeus Nov 21, 2024
@LinkIsGrim LinkIsGrim merged commit f9ac825 into acemod:master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants