Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add a per body part damage cap #10471

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Cplhardcore
Copy link
Contributor

@Cplhardcore Cplhardcore commented Nov 2, 2024

When merged this pull request will:

  • Adds a body part damage cap to prevent excessive wounds

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Cplhardcore
Copy link
Contributor Author

For reference, this is the damage done by a vanilla AK-12, with a damage cap of 40
damage cap 40

and this is the damage done by a vanilla AK-12, with a damage cap of 120
damage cap 120

@Cplhardcore Cplhardcore marked this pull request as ready for review November 2, 2024 22:01
@johnb432
Copy link
Contributor

johnb432 commented Nov 3, 2024

Can you elaborate on why this is needed/wanted? Atm I don't see the point of this.

@Cplhardcore
Copy link
Contributor Author

Cplhardcore commented Nov 3, 2024

Can you elaborate on why this is needed/wanted? Atm I don't see the point of this.

One of the complaints i hear about Ace Medical is the unrealistic amount of wounds one can receive when their unit medical settings are lenient, making it so medics cannot treat them and they have to respawn, this allows units to "cap" damage to a realistic amount to allow medics the chance of treatment without making it super easy for them

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432
Copy link
Contributor

johnb432 commented Nov 5, 2024

One of the complaints i hear about Ace Medical is the unrealistic amount of wounds one can receive when their unit medical settings are lenient, making it so medics cannot treat them and they have to respawn, this allows units to "cap" damage to a realistic amount to allow medics the chance of treatment without making it super easy for them

Fair enough. Is there a combination of medical settings that could make a unit unkillable?


I'd like to have a setting that turns this off completely (either in the slider or a separate setting).

@Cplhardcore
Copy link
Contributor Author

Fair enough. Is there a combination of medical settings that could make a unit unkillable?

Fatal damage source to large hits, Fatal damage chance set to 0, fatal injuries never, 30 minute CA timer and no bleedout,
Had a op like that and sat uncon for 25 minutes

I'd like to have a setting that turns this off completely (either in the slider or a separate setting).

We could make the default the max, which is a lot of wounds even with the cap in place

@johnb432
Copy link
Contributor

johnb432 commented Nov 7, 2024

Fatal damage source to large hits, Fatal damage chance set to 0, fatal injuries never, 30 minute CA timer and no bleedout, Had a op like that and sat uncon for 25 minutes

I apologize for being unclear. What I wanted to know is if this setting would allow someone to be invincible (as in damage is possible, but it's limited) and remain conscious the whole time. E.g. say if you set the this new setting's value to its lowest possible, and the damage threshold to its maximum.

I just don't want to introduce (other) scenarios where one can be an unstoppable juggernaut.

@Cplhardcore
Copy link
Contributor Author

I apologize for being unclear. What I wanted to know is if this setting would allow someone to be invincible (as in damage is possible, but it's limited) and remain conscious the whole time. E.g. say if you set the this new setting's value to its lowest possible, and the damage threshold to its maximum.

I just don't want to introduce (other) scenarios where one can be an unstoppable juggernaut.

In my testing, no, it doesn't, as it still creates enough wounds to KO someone
(although, my testing has been majorily against AI)

@mazinskihenry
Copy link

It might be nice to add something which forces some event if the unit is damaged above the damage cap, like an immediate call to uncon or cardiac arrest. This could also be another CBA setting.

@Cplhardcore
Copy link
Contributor Author

It might be nice to add something which forces some event if the unit is damaged above the damage cap, like an immediate call to uncon or cardiac arrest. This could also be another CBA setting.

I disagree, as there isn't a time when someone will hit max damage and still be conscious, even with a bleed rate of 0.1 and the most lenient of settings

This isn't a PR to cap the wounds at a level where people will be a tank, its moreso a PR to prevent excessive wounds from edge cases

@mazinskihenry
Copy link

It might be nice to add something which forces some event if the unit is damaged above the damage cap, like an immediate call to uncon or cardiac arrest. This could also be another CBA setting.

I disagree, as there isn't a time when someone will hit max damage and still be conscious, even with a bleed rate of 0.1 and the most lenient of settings

This isn't a PR to cap the wounds at a level where people will be a tank, its moreso a PR to prevent excessive wounds from edge cases

What about if someone is TQed? Or if a group decides to have a very low max damage cap specifically because they don't want a million wounds to damage? I feel like there are use cases for this.

@Cplhardcore
Copy link
Contributor Author

It might be nice to add something which forces some event if the unit is damaged above the damage cap, like an immediate call to uncon or cardiac arrest. This could also be another CBA setting.

I disagree, as there isn't a time when someone will hit max damage and still be conscious, even with a bleed rate of 0.1 and the most lenient of settings
This isn't a PR to cap the wounds at a level where people will be a tank, its moreso a PR to prevent excessive wounds from edge cases

What about if someone is TQed? Or if a group decides to have a very low max damage cap specifically because they don't want a million wounds to damage? I feel like there are use cases for this.

Its the same behavior as before, so if they wouldn't go uncon without this PR they wouldn't go uncon with it,

As for a low damage cap, the lowest it goes to is 40, which is still 20+ large avulsions, with how it works currently

@johnb432
Copy link
Contributor

Setting fatal damage sources to sum of trauma, AI critical damage threshold to 25, body part cap to 30 and shooting an AI in the torso (with or without armor) with an AKM at point blank range makes them go uncon, but they are unkillable by bullets - they only die by bleeding out (which happens quickly, given the amount of bleeding).

I'm torn on the issue: Those are stupid settings, but imo stupid settings shouldn't be possible. At the same time, I understand having the minimum at 30. Need more opinions on this.

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants