Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - Add Additional Hitpoints to the medical system #10482
base: master
Are you sure you want to change the base?
Medical - Add Additional Hitpoints to the medical system #10482
Changes from 7 commits
a38767b
4f03f3c
2d0f1a9
71daaa7
434f709
9243175
c6effc9
305654d
822019f
97c9fd4
f4f3905
7c78535
2aeda77
0737077
799c794
b6b1225
5b8e144
6fbea5a
fd4c4cd
9961493
1810f08
7270e8d
ac42769
4b119bf
263fbca
ef08054
3c906ce
09db653
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function needs handling of previous format of bodyPartDamage array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For BWC? or is there something else I am oblivious to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems arbitrary. Can this not be handled via medical_engine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as the hitbox for neck damage is unbelievably small, to the point its impossible to hit
Plus jaw/lower head damage still affects the neck area
Check notice on line 47 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / windows
assignment to if can be replaced with select
Check notice on line 47 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / build
assignment to if can be replaced with select
Check notice on line 52 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / windows
assignment to if can be replaced with select
Check notice on line 52 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / build
assignment to if can be replaced with select
Check notice on line 53 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / windows
assignment to if can be replaced with select
Check notice on line 53 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / build
assignment to if can be replaced with select
Check notice on line 54 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / windows
assignment to if can be replaced with select
Check notice on line 54 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / build
assignment to if can be replaced with select
Check notice on line 55 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / windows
assignment to if can be replaced with select
Check notice on line 55 in addons/medical_damage/functions/fnc_woundsHandlerBase.sqf
GitHub Actions / build
assignment to if can be replaced with select
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break KAM FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i am aware, ill have to do my own refactor of KAM with these changes if they do get merged