New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat SPE - Add Tank cannon overpressure and shell fragmentation #10502

Merged

PabstMirror merged 42 commits into acemod:master from jpspider1:ACE3-SPE-compat-update-branch

Nov 23, 2024

Contributor

jpspider1 commented Nov 11, 2024 •

edited

Loading

When merged this pull request will:

HE and AP shells (for AP shells only those that would have had filler and aren't solid shot) for all German and American Tanks will have Fragmentation values added
New shells.hpp created to encompass all shell fragmentations
2cm Flak bullet has fragmentation under bullet.hpp
CfgAmmo.hpp will include new shells.hpp with changes
SPE_TankCannon_base will have basic ACE Overpressure values from wiki
SPE_TankCannon_base added in \compat_spe\CfgWeapons\cannons.hpp

jpspider1 added 8 commits

November 11, 2024 13:59


          ~ Added: Shells.hpp and German HE tank shells

433a701


          ~ Added: American tank HE Shells

71a212f


          ~ Added: American 57mm AT Gun HE shell

6b50785


          ~ Added: Include line for shells in CfgAmmo.hpp

804df64


          ~ Added: Base ACE Overpressure to all SPE cannons

3f52eb3


          ~ Added: Fragmentation for 2cm flak

d7a7477


          ~ Removed: Existing Sherman HE shell values

eca9ecf


          ~ Changed: gurney_C of all German shells to 2930

fa7082f

veteran29 added the kind/feature label

veteran29 added this to the 3.18.2 milestone

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgWeapons/cannons.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgWeapons/cannons.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

DartRuffian reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/shells.hpp Outdated Show resolved Hide resolved

jpspider1 and others added 9 commits

November 12, 2024 11:44


          Update addons/compat_spe/CfgAmmo/shells.hpp

546af77

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

fd20c44

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

8ca9670

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

3d64d16

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

edf618e

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

4e2979a

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

43aebec

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

bf1507d

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>


          Update addons/compat_spe/CfgAmmo/shells.hpp

19913a0

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>

Contributor Author

jpspider1 commented Nov 12, 2024

I think I will also add ACE fragmentation parameters to SPE HEAT shells and some APHE shells. I think APCR and solid AP shot will not have any ACE fragmentation.

jpspider1 added 6 commits

November 12, 2024 17:38


          ~ Added: Fragmentation to German AP and HEAT

bfd6dfc


          ~ Added: American AP Fragmentation

2ffefda


          ~ Added: American AT and Howitzer Fragmentation

1f026f6


          ~ Added: Greyhound HE fragmentation

b26de2b


          ~ Added: Inheritance SPE_Shell_base

5afc219


          ~ Added: Overpressure priority. Not on wiki.

2feeae7

LinkIsGrim approved these changes

View reviewed changes

LinkIsGrim added the area/compatibility label

PabstMirror reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved

PabstMirror reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved

PabstMirror approved these changes

View reviewed changes

Contributor

PabstMirror left a comment

everything looks reasonable to me

jpspider1 and others added 2 commits

November 15, 2024 10:07


          Update addons/compat_spe/CfgAmmo/bullets.hpp

2bd28a8

Co-authored-by: PabstMirror <pabstmirror@gmail.com>


          Update addons/compat_spe/CfgAmmo/bullets.hpp

ed515d9

Co-authored-by: PabstMirror <pabstmirror@gmail.com>

johnb432 reviewed

View reviewed changes

addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved


          Update addons/compat_spe/CfgAmmo/bullets.hpp

68e0bed

PabstMirror enabled auto-merge (squash)

November 23, 2024 19:59

PabstMirror merged commit 13ddde0 into acemod:master

3 checks passed

LinkIsGrim changed the title ~~SPE Compat - Add Tank cannon overpressure and shell fragmentation~~ Compat SPE - Add Tank cannon overpressure and shell fragmentation

LinkIsGrim added kind/enhancement and removed kind/feature labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compatibility kind/enhancement