Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Show DLC Requirement Image #10506

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Arsenal - Show DLC Requirement Image #10506

wants to merge 15 commits into from
+108 −6

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:

  • Adds an option to show the required DLC ownership instead of which DLC introduced the item
  • I'm not sure if there are any more exceptions, RF changes the MRD model of the vanilla object, which I am imagine means it isn't DLC restricted, but I can not confirm as I own all the DLCs

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@BrettMayson BrettMayson changed the title Arsenal - Show DLC REquirement Arsenal - Show DLC Requirement Image Nov 12, 2024
johnb432
johnb432 reviewed Nov 12, 2024
View reviewed changes
addons/arsenal/stringtable.xml Outdated Show resolved Hide resolved
addons/common/functions/fnc_getDLC.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getDLC.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getDLC.sqf Outdated Show resolved Hide resolved
BrettMayson and others added 6 commits November 12, 2024 12:22
@BrettMayson @johnb432
Update addons/common/functions/fnc_getDLC.sqf
99d388c 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@BrettMayson @johnb432
Update addons/common/functions/fnc_getDLC.sqf
3c050b8 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@BrettMayson @johnb432
Update addons/common/functions/fnc_getDLC.sqf
32865c4 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@BrettMayson
Merge remote-tracking branch 'upstream/master' into arsenaL_dlc_requi…
ba356df 
…rement
@BrettMayson
sort and fix duplicate
bb4a6eb
@BrettMayson
use getAssetDLCInfo
48b23eb
@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** kind/setting Release Notes: **SETTINGS:** labels Nov 13, 2024
@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Nov 13, 2024
LinkIsGrim
LinkIsGrim reviewed Nov 13, 2024
View reviewed changes
addons/common/functions/fnc_getDLC.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getDLC.sqf Outdated Show resolved Hide resolved
@DartRuffian
Copy link
Contributor

I don't have any CDLC if you need something tested

@LinkIsGrim @DartRuffian
Update addons/common/functions/fnc_getDLC.sqf
98bc583 
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
johnb432 and others added 2 commits November 17, 2024 00:25
@johnb432 @DartRuffian
Update addons/arsenal/initSettings.inc.sqf
aa41abe 
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
@johnb432
Merge branch 'master' into pr/10506
c107008
@BrettMayson @johnb432
Update addons/common/functions/fnc_getDLC.sqf
38c2fd1 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim left review comments

@DartRuffian DartRuffian DartRuffian left review comments

@johnb432 johnb432 johnb432 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
4 participants
@BrettMayson @DartRuffian @johnb432 @LinkIsGrim