Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations - Improve Japanese (Before EF release) #10511

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

Apricot-ale
Copy link
Contributor

When merged this pull request will:

  • Better sentence for Japanese
  • add missing STR_ACE_Goggles_SettingDrawOverlay localization for Japanese

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Apricot-ale Apricot-ale marked this pull request as draft November 15, 2024 22:01
@Apricot-ale Apricot-ale changed the title Translations - Improve Japanese (goggle and sentence) Translations - Improve Japanese (Part 2) Nov 15, 2024
@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 15, 2024
@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label Nov 15, 2024
@Apricot-ale Apricot-ale changed the title Translations - Improve Japanese (Part 2) Translations - Improve Japanese (Before EF release) Nov 19, 2024
@Apricot-ale Apricot-ale marked this pull request as ready for review November 19, 2024 18:51
@Apricot-ale
Copy link
Contributor Author

Currently, almost all of the PRs flagged for 3.18.2 that have been submitted have been translated into Japanese.
The only ones that are not yet completed are the following PRs:
OverlordZorn#1
DartRuffian#2

@PabstMirror PabstMirror merged commit 38911e4 into acemod:master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants