Medical - Add more API getters

[DartRuffian]

When merged this pull request will:

• Add API for checking if a unit has any injuries
  • Uses medical_ai's isInjured function
• Add API for getting a unit's blood loss
  • Uses medical_status's getBloodLoss function

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

EFUNC(medical_ai,isInjured) only checks if the unit has broken legs, it doesn't check for broken arms. It also returns true if the unit is unconscious.

What purpose should this new function serve?
As it is atm, imo you are asking it to do too much, making it not very useful in my eyes.

[DartRuffian]

What purpose should this new function serve?

For my use-case, it was checking for "non-normal" medical state. I.e. true if uncon, has wounds, etc.
It was for a medevac script and I only wanted the action to show if the unit was actually injured.

I could've checked all of the variables myself, but I figured an API function would be more useful.

[DartRuffian]

EFUNC(medical_ai,isInjured) only checks if the unit has broken legs, it doesn't check for broken arms. It also returns true if the unit is unconscious.

Should the medical_ai function check for broken arms as well?
I included it just in the API function for now, but I can just update the AI function if desired.

[johnb432]

Should the medical_ai function check for broken arms as well?

No, it was intentionally done like that for (to me unknown) reason, although my guess would be that 1) AI don't have a lot of splints, 2) AI don't suffer from AI sway as players do (so don't waste them) and 3) might have simplified the AI medic state machine by not having to add a priority system for which limbs to splint (is now a moot point, because I revamped the state machine quite a bit).

What is the AI function completely omits is blood level and HR checking. I'll need to check whether this is intentional or not, but regardless the API function needs to check for the blood level at the very least. I'd imagine that having a high/low HR should also make the API return true, but then there might be certain scenarios where you simply don't care.

That leads me to: what's the formal definition of "non-normal"?

[DartRuffian]

I'd define "non-normal" as a state differing from the state set by initUnit / fullHeal

[LinkIsGrim]

!(lifeState unit in ["HEALTHY", "somethingElseIForgot"])

[DartRuffian]

Are you suggesting that should be added in the check as well?

Ah, I thought IS_UNCON was updated to use common's isAwake function. I'll update that

[DartRuffian]

!(lifeState unit in ["HEALTHY", "somethingElseIForgot"])

"INJURED", and I opted to just use common_fnc_isAwake. Unless it should explicity check lifeState instead of the common function?

[DartRuffian]

Making a checklist of things for fnc_isInjured. Not explicitly saying all of these should be considered.

• Fractured limbs
  • Arms are checked in API function, legs are checked in medical_ai_fnc_isInjured
• Blood volume
• Blood pressure
• Peripheral resistance
• Oxygen demand
• Open wounds
• Unconsciousness
• Tourniquets
• Pain
• Heart rate
• SPO2

[LinkIsGrim]

SPO2, Heart Rate, Blood Pressure and Oxygen Demand can't just be checked against default as they can vary with fatigue and altitude if SPO2 simulation is enabled.

[DartRuffian]

I just added those to have them listed, I don't think any of them should be considered IMO

[LinkIsGrim]

Not necessarily an indication of injury. Maybe stable condition, but not injury.

[DartRuffian]

I misunderstood your comment (#10514 (comment)) then, I thought you were suggesting to check that as well