Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction - Define _actionParams #10527

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Interaction - Define _actionParams #10527

merged 6 commits into from
Dec 13, 2024

Conversation

OverlordZorn
Copy link
Contributor

When merged this pull request will:

  • make the actions parameters accessible within statement and condition through _actionParams to bring it in line with the behavior of _player and _target

@PabstMirror
Copy link
Contributor

also need to change ace_interact_menu_fnc_render

@PabstMirror PabstMirror added this to the 3.18.2 milestone Dec 4, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Dec 4, 2024
@PabstMirror
Copy link
Contributor

I think we'll also want it for https://github.com/acemod/ACE3/blob/master/addons/interact_menu/functions/fnc_collectActiveActionTree.sqf#L31

where the modifyer and conditions are checked

@PabstMirror PabstMirror self-assigned this Dec 8, 2024
@LinkIsGrim LinkIsGrim merged commit f6a38c4 into acemod:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees

@PabstMirror PabstMirror

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
3 participants
@OverlordZorn @PabstMirror @LinkIsGrim