Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuel - Fix editor fuel sources #10536

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Dec 8, 2024

When merged this pull request will:

  • Refuel sources defined via the eden editor attributes didn't have their fuel added, as the QGVAR(initSource) EH was registered too late, making it miss all calls at mission start. Even if the EH was registered earlier, the actions weren't.
    This PR moves both the EH and actions into post init, not waiting for the CBA settings to be initialised.
  • See: https://discord.com/channels/976165959041679380/1312983103551045733/1312983103551045733

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Dec 8, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Dec 8, 2024
@PabstMirror PabstMirror merged commit 61fa8c5 into master Dec 8, 2024
3 checks passed
@PabstMirror PabstMirror deleted the refuel-fix-editor-fuel-sources branch December 8, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants